Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

[feature] project view supports import_depth #248

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

sellophane
Copy link
Contributor

@sellophane sellophane commented May 26, 2022

@sellophane sellophane marked this pull request as ready for review May 26, 2022 13:20
@sellophane sellophane force-pushed the import_depth branch 2 times, most recently from dba3325 to af1835f Compare May 26, 2022 13:50
Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot, I love the change!

some annoying nitpicking from my side

@abrams27
Copy link
Member

abrams27 commented May 30, 2022

@agluszak agluszak changed the title Adding ability to set importing depth for targets Add ability to set importing depth for targets May 30, 2022
Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+not resolved comments

Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final things and we can merge

Copy link
Member

@abrams27 abrams27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, thanks a lot!

the final thing, please update the changelog

@abrams27 abrams27 changed the title Add ability to set importing depth for targets [feature] project view supports import_depth Jun 2, 2022
@sellophane
Copy link
Contributor Author

great work, thanks a lot!

the final thing, please update the changelog

Changelog changed

@abrams27 abrams27 merged commit 221e7cb into JetBrains:master Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants