-
Notifications
You must be signed in to change notification settings - Fork 46
[feature] project view supports import_depth
#248
Conversation
dba3325
to
af1835f
Compare
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/BazelProjectMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/dependencytree/DependencyTree.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot, I love the change!
some annoying nitpicking from my side
...ava/org/jetbrains/bsp/bazel/projectview/parser/sections/ProjectViewSingletonSectionParser.kt
Outdated
Show resolved
Hide resolved
...rojectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewBuilderTest.kt
Outdated
Show resolved
Hide resolved
...rojectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewBuilderTest.kt
Outdated
Show resolved
Hide resolved
...rojectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewBuilderTest.kt
Outdated
Show resolved
Hide resolved
...rojectview/src/test/java/org/jetbrains/bsp/bazel/projectview/model/ProjectViewBuilderTest.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/dependencytree/DependencyTree.kt
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/dependencytree/DependencyTree.kt
Outdated
Show resolved
Hide resolved
server/src/test/java/org/jetbrains/bsp/bazel/server/sync/dependencytree/DependencyTreeTest.kt
Outdated
Show resolved
Hide resolved
server/src/test/java/org/jetbrains/bsp/bazel/server/sync/dependencytree/DependencyTreeTest.kt
Outdated
Show resolved
Hide resolved
server/src/test/java/org/jetbrains/bsp/bazel/server/sync/dependencytree/DependencyTreeTest.kt
Outdated
Show resolved
Hide resolved
ohh and changelog and https://github.com/JetBrains/bazel-bsp/tree/master/executioncontext/projectview update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+not resolved comments
install/src/main/java/org/jetbrains/bsp/bazel/install/cli/CliOptionsProvider.kt
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/BazelProjectMapper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/jetbrains/bsp/bazel/server/sync/dependencytree/DependencyTree.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final things and we can merge
install/src/main/java/org/jetbrains/bsp/bazel/install/cli/CliOptionsProvider.kt
Outdated
Show resolved
Hide resolved
...econtext/src/test/java/org/jetbrains/bsp/bazel/workspacecontext/ImportDepthSpecMapperTest.kt
Show resolved
Hide resolved
...econtext/src/test/java/org/jetbrains/bsp/bazel/workspacecontext/ImportDepthSpecMapperTest.kt
Outdated
Show resolved
Hide resolved
...econtext/src/test/java/org/jetbrains/bsp/bazel/workspacecontext/ImportDepthSpecMapperTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, thanks a lot!
the final thing, please update the changelog
import_depth
Changelog changed |
https://youtrack.jetbrains.com/issue/BAZEL-87