This repository has been archived by the owner on Aug 5, 2024. It is now read-only.
[fix] parsing of project view file fails if the file doesn't exist | #BAZEL-21 Fixed | #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrams27
changed the title
abrams27
changed the title
abrams27
force-pushed
the
issue-21-project-view-parsing-fail
branch
from
1d9611c to
b7881ec
Compare
lukaszwawrzyk
approved these changes
Apr 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now parsing of project view fails if the file doesn't exist, also now implementation is in kotlin (it still needs some love, to become a good kotlin code, but I'll do it later anyway) + mock parser is better - it uses entire logic of the real implementation
https://youtrack.jetbrains.com/issue/BAZEL-21
testing: