This repository has been archived by the owner on Aug 5, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented ProjectStorage to store
Project
between runs.I introduced
bspClientLogger.timed("Operation", () -> {})
to time and report some long operations.I refactored BazelData to be BazelInfo (as the output of bazel info) and created BspInfo as it is messy to have everything in one object and introduces unnecessary dependencies.
I renamed BuildClientLogger -> BspClientLogger. I think it will be more clear now that it logs to the bsp client.
There is one more change here, could be a separate PR but I was lazy (sorry).
In case of aborted event from BEP which happens when some BUILD files are incorrect for example, I send a warning to bsp client (also client sees build output that explains the error precisely). With the exception approach, client sees a lot of ugly (new line between each actual line) stacktraces (the stacktrace doesn't help with anything, it is just form bep). Not sure why this exception doesn't interrupt the import, but it shouldn't anyway. We want to import a project at least partially even if it doesn't build.
fixes #205