Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent name, family and style properties #274

Closed
trygveaa opened this issue Jul 13, 2020 · 3 comments
Closed

Inconsistent name, family and style properties #274

trygveaa opened this issue Jul 13, 2020 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@trygveaa
Copy link

trygveaa commented Jul 13, 2020

The name for ExtraLight doesn't have a space while Extra Bold and Semi Light have it:

$ for f in *; do echo -n "$f\t"; fc-query $f | grep fullname:; done | column -t -s'	'
JetBrainsMono-Bold-Italic.ttf          fullname: "JetBrains Mono Bold Italic"(s)
JetBrainsMono-Bold.ttf                 fullname: "JetBrains Mono Bold"(s)
JetBrainsMono-ExtraBold-Italic.ttf     fullname: "JetBrains Mono Extra Bold Italic"(s)
JetBrainsMono-ExtraBold.ttf            fullname: "JetBrains Mono Extra Bold"(s)
JetBrainsMono-ExtraLight-Italic.ttf    fullname: "JetBrains Mono ExtraLight Italic"(s)
JetBrainsMono-ExtraLight.ttf           fullname: "JetBrains Mono ExtraLight"(s)
JetBrainsMono-Italic.ttf               fullname: "JetBrains Mono Italic"(s)
JetBrainsMono-Light-Italic.ttf         fullname: "JetBrains Mono Light Italic"(s)
JetBrainsMono-Light.ttf                fullname: "JetBrains Mono Light"(s)
JetBrainsMono-Medium-Italic.ttf        fullname: "JetBrains Mono Medium Italic"(s)
JetBrainsMono-Medium.ttf               fullname: "JetBrains Mono Medium"(s)
JetBrainsMono-Regular.ttf              fullname: "JetBrains Mono Regular"(s)
JetBrainsMono-SemiLight-Italic.ttf     fullname: "JetBrains Mono Semi Light Italic"(s)
JetBrainsMono-SemiLight.ttf            fullname: "JetBrains Mono Semi Light"(s)

To be consistent with the dashes in the file names, I guess the spaces should be removed.

Some of the variants have a specific family, while some don't:

$ for f in *; do echo -n "$f\t"; fc-query $f | grep family:; done | column -t -s'	'
JetBrainsMono-Bold-Italic.ttf          family: "JetBrains Mono"(s)
JetBrainsMono-Bold.ttf                 family: "JetBrains Mono"(s)
JetBrainsMono-ExtraBold-Italic.ttf     family: "JetBrains Mono"(s) "JetBrains Mono Extra Bold"(s)
JetBrainsMono-ExtraBold.ttf            family: "JetBrains Mono"(s) "JetBrains Mono Extra Bold"(s)
JetBrainsMono-ExtraLight-Italic.ttf    family: "JetBrains Mono"(s) "JetBrains Mono ExtraLight"(s)
JetBrainsMono-ExtraLight.ttf           family: "JetBrains Mono"(s) "JetBrains Mono ExtraLight"(s)
JetBrainsMono-Italic.ttf               family: "JetBrains Mono"(s)
JetBrainsMono-Light-Italic.ttf         family: "JetBrains Mono"(s) "JetBrains Mono Light"(s)
JetBrainsMono-Light.ttf                family: "JetBrains Mono"(s) "JetBrains Mono Light"(s)
JetBrainsMono-Medium-Italic.ttf        family: "JetBrains Mono"(s) "JetBrains Mono Medium"(s)
JetBrainsMono-Medium.ttf               family: "JetBrains Mono"(s) "JetBrains Mono Medium"(s)
JetBrainsMono-Regular.ttf              family: "JetBrains Mono"(s)
JetBrainsMono-SemiLight-Italic.ttf     family: "JetBrains Mono"(s) "JetBrains Mono Semi Light"(s)
JetBrainsMono-SemiLight.ttf            family: "JetBrains Mono"(s) "JetBrains Mono Semi Light"(s)

Some variants have Italic or Regular specified separately in style, while some don't.

$ for f in *; do echo -n "$f\t"; fc-query $f | grep style:; done | column -t -s'	'
JetBrainsMono-Bold-Italic.ttf          style: "Bold Italic"(s)
JetBrainsMono-Bold.ttf                 style: "Bold"(s)
JetBrainsMono-ExtraBold-Italic.ttf     style: "Extra Bold Italic"(s) "Italic"(s)
JetBrainsMono-ExtraBold.ttf            style: "Extra Bold"(s) "Regular"(s)
JetBrainsMono-ExtraLight-Italic.ttf    style: "ExtraLight Italic"(s) "Italic"(s)
JetBrainsMono-ExtraLight.ttf           style: "ExtraLight"(s) "Regular"(s)
JetBrainsMono-Italic.ttf               style: "Italic"(s)
JetBrainsMono-Light-Italic.ttf         style: "Light Italic"(s) "Italic"(s)
JetBrainsMono-Light.ttf                style: "Light"(s) "Regular"(s)
JetBrainsMono-Medium-Italic.ttf        style: "Medium Italic"(s) "Italic"(s)
JetBrainsMono-Medium.ttf               style: "Medium"(s) "Regular"(s)
JetBrainsMono-Regular.ttf              style: "Regular"(s)
JetBrainsMono-SemiLight-Italic.ttf     style: "Semi Light Italic"(s) "Italic"(s)
JetBrainsMono-SemiLight.ttf            style: "Semi Light"(s) "Regular"(s)

This is with version 2.001.

@philippnurullin
Copy link
Member

Hi @trygveaa, i'm assuming you looking at the Name table strings.

Screenshot 2,3 are results of naming strategy for older Microsoft applications. This is based on logic that every font have only 4 styles (Regular, Italic, Bold, Bold Italic). Any other weights is separated by isolated Family.

Regarding exact file names i preferred that we didn't change that because of an issues like that #269 . What problems do you think it will bring if we don't change them?

The issue that can be definitely addressed here is naming of Extra Light. I will correct that in the next update.

@trygveaa
Copy link
Author

Hi @trygveaa, i'm assuming you looking at the Name table strings.

I'm just looking at the output of the fc-query command.

Screenshot 2,3 are results of naming strategy for older Microsoft applications. This is based on logic that every font have only 4 styles (Regular, Italic, Bold, Bold Italic). Any other weights is separated by isolated Family.

Okay, I understand.

Regarding exact file names i preferred that we didn't change that because of an issues like that #269 . What problems do you think it will bring if we don't change them?

I didn't mean that you should change the file names. I just thought the full names should be consistent with them, so the spaces in the full name corresponds to dashes in the file name. But when I think about it, that's not the case with "JetBrains Mono" either,since that has a space in the full name, but nothing in the file name. But it doesn't really matter that much, and as you said, changing it now is probably not a good idea.

The issue that can be definitely addressed here is naming of Extra Light. I will correct that in the next update.

Yes, perhaps this is the only real issue here.

@philippnurullin philippnurullin added this to the v2.002 milestone Jul 16, 2020
@philippnurullin philippnurullin added the bug Something isn't working label Aug 26, 2020
philippnurullin added a commit that referenced this issue Aug 27, 2020
— Changed license from Apache 2.0. to SIL 1.1.
— Corrected Extra Light weight name in metadata #274
@nim-nim
Copy link

nim-nim commented Sep 7, 2020

FYI the font metadata fixup guidelines in Fedora Linux require removing spaces from Width Weight Slant qualifiers in font naming, to make sure each axis qualifier uses a single space-less keyword (ie SemiCondensed ExtraLight Italic, never Semi Condensed Extra Light Italic)

This is consistent with Microsoft’s WPF font model whitepaper, that already noted that using spaces in WWS keywords added several orders of complexity to style parsing in applications.

Most first-rank font projects already apply this rule, and do not need any fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants