Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italic variant broken #266

Closed
atauzki opened this issue Jul 11, 2020 · 15 comments
Closed

Italic variant broken #266

atauzki opened this issue Jul 11, 2020 · 15 comments
Labels
bug Something isn't working

Comments

@atauzki
Copy link

atauzki commented Jul 11, 2020

OS:Windows 10 build 19041.0
JetBrains Mono:2.0
Editor:Visual Studio Code 1.47.0

expected display(v1.0.6):
image

what it looks like on 2.0:
image

@philippnurullin
Copy link
Member

philippnurullin commented Jul 11, 2020

Hi @atauzki , did you install the new version on top of the old? To confirm please delete all JetBrains Mono fonts from OS & reinstall the latest version.

@atauzki
Copy link
Author

atauzki commented Jul 11, 2020

yeah, I uninstalled the old version and installed newest version. and this issue happend.

@philippnurullin
Copy link
Member

Ok, i will continue to investigate this problem on monday.

@saidattax
Copy link

Same problem with me on VSCode

Windows 10 Version - 10.0.18363 Build 18363
VSCode 1.47.0

Although it works fine with Sublime Text 3

@atauzki Does italic work fine for you on Sublime Text 3?

@atauzki
Copy link
Author

atauzki commented Jul 11, 2020

The problem caused by the inconsistent width attribute.
image
image
When I changed the width to normal with FontCreator, the italic style displayed fine.

@philippnurullin
Copy link
Member

Yes, confirm that. My bad, will fix this asap.

@philippnurullin philippnurullin added the bug Something isn't working label Jul 11, 2020
@astrolemonade
Copy link

Will a quick fix release come this week ?

@philippnurullin
Copy link
Member

philippnurullin commented Jul 12, 2020

@cata0309 Yes.

@amsokol
Copy link

amsokol commented Jul 12, 2020

Hi @atauzki. Sorry for off-topic. Have you succeeded to turn on semi light font weight for VSCode? Set "editor.fontWeight" to "350" works fine for "Cascadia Code" font but does not work for "JetBrains Mono" font.

@astrolemonade
Copy link

Any updates @philippnurullin ?

@philippnurullin
Copy link
Member

philippnurullin commented Jul 12, 2020

@cata0309 Sorry i missguided you. Right now it's holiday. I will fix this on Monday, when my working hours will start.

@astrolemonade
Copy link

astrolemonade commented Jul 12, 2020 via email

@atauzki
Copy link
Author

atauzki commented Jul 13, 2020

Hi @atauzki. Sorry for off-topic. Have you succeeded to turn on semi light font weight for VSCode? Set "editor.fontWeight" to "350" works fine for "Cascadia Code" font but does not work for "JetBrains Mono" font.

No. you may create another issue.

philippnurullin added a commit that referenced this issue Jul 13, 2020
— Corrected proportion string in metadata in Italic #266
— Changed the naming of source files to match previous
@atauzki
Copy link
Author

atauzki commented Jul 13, 2020

Static works but variable font still broken in 2.001.Their family name are different.

@philippnurullin
Copy link
Member

@atauzki This is done on purpose. More in the issue. #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants