Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficult to tell difference between opening and closing curly quote #237

Closed
Fjan opened this issue May 5, 2020 · 4 comments
Closed

Difficult to tell difference between opening and closing curly quote #237

Fjan opened this issue May 5, 2020 · 4 comments

Comments

@Fjan
Copy link

Fjan commented May 5, 2020

First off, I love this font and have it now set as my default programming font.

One small issue I ran into is that curly quotes are rarely used in programming, but if they are it's important to tell the difference between ’ and ’. Currently those two look almost exactly the same at size 13. For the curly double quote, I can also only barely make out the difference between “ and ”.

I would argue that for a programming font it's more important to be able to tell which character it is than to make it look pretty. Can we please consider making the curly quotes look more like inverted commas so they clearly stand out?

@trygveaa
Copy link

trygveaa commented May 5, 2020

’ and ’

These two characters are the same. I assume you meant ‘ and ’.

One small issue I ran into is that curly quotes are rarely used in programming

Which language(s) uses these?

Can we please consider making the curly quotes look more like inverted commas so they clearly stand out?

What do you mean? As far as I can see ’ looks exactly the same as comma, but is placed in the top, and ‘ is the same but upside down.

I agree that it's hard to see a difference at normal font sizes though.

@Fjan
Copy link
Author

Fjan commented May 5, 2020

Ah yes, ‘ and ’, sorry 😀
My specific use case is that I often work on scripts that contain user provided input, and in that case I need to process / filter text that contains these characters. They are typically copy/pasted from somewhere else.

But we also often need to edit documentation pages in markdown / yaml / erb format that are run through a static site generator to turn into HTML, and those tend to contain curly quotes sometimes as well.

I was thinking of curly quotation marks that are actually curly as in a serif font as seen here: https://en.wikipedia.org/wiki/Quotation_mark

@martin-sucha
Copy link

Hey, I've hit this same issue.

I'm editing a website source code and need to fix occurrences of quotes so that the text on the website is properly formatted. It's hard to tell the difference between “ and ” unless I zoom or look very closely.

Please make the difference more visible.

philippnurullin added a commit that referenced this issue Sep 24, 2021
- Removed conflicting unicode from Control Codes #491
- Remade the Control Codes from scratch. Made them bigger.
- Remade the ‚ „ “ ” ‘ ’ for better recognition #237 #489
- Added new ligatures {{ }} {!-- {{-- --}} {!! !!} #359
@philippnurullin
Copy link
Member

Remade quotation marks in the latest push. You can grab the files here https://github.com/JetBrains/JetBrainsMono/tree/master/fonts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants