Postgres ignore + replace #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make pg replace only use primary keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #290
This PR attempts to add support for ignore and replace
From what I've looked up, ignore involves simply adding
ON CONFLICT DO NOTHING.Replace is a bit different for postgres, as it goes through ignore and calls update on conflicts. It also needs to specify which keys to look out for conflicts, which is why I've made it default to the unique keys (snippet taken from the H2 code).
This was tested against this code
The dependency is passed through jitpack, so it's easy to tweak something and update the import
On top of this, I have one question:
The replace method for PG looks similar to ignore from H2. Isn't ignore not supposed to update rows and just stop on conflict?
Once I have a better idea of what's going on I can document the arguments so it's clearer for people like me who are new to sql