Features/#277 create missing env file #445
Conversation
src/main/kotlin/com/jetbrains/snakecharm/lang/psi/SmkFileReference.kt
Outdated
Show resolved
Hide resolved
| val targetName = tokens.lastOrNull() ?: return | ||
| var currentFile = file.virtualFile.parent | ||
| try { | ||
| tokens.forEach { |
There was a problem hiding this comment.
It is reasonable to expect, that in such complicated application, like IntelliJ platform the task of creating file by relative path + create intermediate dirs isn't a rare case and already solved via some API. The code below is bicycle invention in a rather complected way. E.g. java.io already have methods for creating files and folders. So here we could use smth like:
val targetFile = file.virtualFile.parent.findFileByRelativePath(fileName)
// if targetFile == null ....
val targetFileFolder = targetFile.parent
VfsUtil.createDirectoryIfMissing(targetFileFolder.path)
LocalFileSystem.getInstance().createChildFile(this, targetFileFolder, targetFile.name)or just:
val targetFile = Paths.get(file.virtualFile.parent.path, fileName)
Files.createDirectories(targetFile.parent)
Files.createFile(targetFile)
|
Also it is good to make this action undoable, try to use UndoableAction interface. |
|
Allows to create files without YAML / YML / yaml / yml suffix, e.g. |
|
Error should like failed to created |
…ction' interface is used now. Resolves: #277
…script, snakefile, configfile, pepfile, pepschema. Resolves: #277
Resolved: #277
…ts tests running (and we're getting "RuntimeException: ... file is invalid: temp:///src/foo.smk ..."). So now we're just checking that there are available quickfix. Resolves: #277
Resolves: #277
| } catch (e: SecurityException) { | ||
| SmkNotifier.notify( | ||
| title = SnakemakeBundle.message("notifier.msg.create.env.file.title"), | ||
| content = SnakemakeBundle.message("notifier.msg.create.env.file.invalid.file.exception", fileName), |
There was a problem hiding this comment.
Is error message is correct here? In which cases Security Exception occurs? Maybe you could show an error like cannot create file and add e.message as error details. Also, it is reasonable to log the exception error and message to the log file. E.g. see PythonParser.LOGGER as an example.
| @@ -134,19 +137,13 @@ INSP.NAME.functions.not.allowed.in.section=Function object cannot be used as a v | |||
| # SmkWildcardNotDefinedInspection | |||
| INSP.NAME.wildcard.not.defined.title=Undefined wildcard usage. | |||
| INSP.NAME.wildcard.not.defined.in.section=Wildcard ''{0}'' isn''t defined in ''{1}'' section. | |||
| INSP.NAME.wildcard.not.defined.in.overridden.rule=Wildcard ''{0}'' isn''t defined in any appropriate section of overridden rules | |||
| INSP.NAME.wildcard.not.defined=Wildcard ''{0}'' isn''t properly defined. | |||
| INSP.NAME.wildcard.not.defined.cannot.check=Cannot check whether wildcard ''{0}'' is defined or not. | |||
There was a problem hiding this comment.
Actually sounds to technical and not clear. If source file changed, that you could just show that source file changed. Please try again. Otherwise not clear what are "parts" of the file? Subdirectories?
| val directoryPath = Files.createDirectories(targetFilePath.parent) | ||
| val directoryVirtualFile = VfsUtil.findFile(directoryPath, true) ?: return@Runnable | ||
| LocalFileSystem.getInstance().createChildFile(this, directoryVirtualFile, targetFilePath.name) | ||
| VirtualFileManager.getInstance().asyncRefresh { } |
There was a problem hiding this comment.
What for do we need refresh here? And why async? Is it a workaround to resart inspections in the current file? According to source code com.intellij.openapi.vfs.impl.local.LocalFileSystemBase.createChildFile does some events publishing.
There was a problem hiding this comment.
Also, not sure that we need to interact with Virtual File System here. 'undo' uses just "java.io.File" standard Java SDK API. Here maybe is better to check existence/create file w/o using VFS api, refresing, etc.
| startElement: PsiElement, | ||
| endElement: PsiElement | ||
| ) { | ||
| val relativeDirectory = |
There was a problem hiding this comment.
Fix doesn't work ok if absolute path is used, e.g.:
rule rule277_s:
conda: "/ednvs/ddd/ddd/dddaaaa.yaml"
script: "env/ddddd.py"
on runtime expects absolute path:
$ snakemake --snakefile rule277.smk --use-conda -c1
Building DAG of jobs...
WorkflowError:
Failed to open source file /ednvs/ddd/ddd/dddaaaa.yaml
FileNotFoundError: [Errno 2] No such file or directory: '/ednvs/ddd/ddd/dddaaaa.yaml'
but quick fixes tries to create a file in project working directory. I assume that it valid for all file references for conda, script, etc sections. E.g. path could be absolute or relative. Is better to check.
…usage was removed wherever it is possible. Resolves: #277
|
Discussed problems were solved. |
#277 Quick fix for missing
.yaml/.ymlfile was implemented.