Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/#384 inspections are enabled for workflows #391

Merged
merged 5 commits into from
Jul 27, 2021
Merged

Features/#384 inspections are enabled for workflows #391

merged 5 commits into from
Jul 27, 2021

Conversation

dakochik
Copy link
Contributor

Issue #384 is resolved

fixed: SmkSectionUnexpectedKeywordArgsInspection, SmkSectionMultipleA…
1a24783 
…rgsInspection are enabled for workflow sections

Resolves: #384
@dakochik dakochik changed the title Issue is resolved Features/#384 inspections are enabled for workflows Jul 22, 2021
iromeo
iromeo requested changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@iromeo iromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow and rule/checkpoint names should be decoupled + please fix also SmkSyntaxErrorAnnotator to highlight as error:

wildcard_constraints:
    foo = ".*",
    foo = ".*"

...ain/kotlin/com/jetbrains/snakecharm/inspections/SmkSectionUnexpectedKeywordArgsInspection.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/jetbrains/snakecharm/inspections/SmkSectionMultipleArgsInspection.kt Outdated Show resolved Hide resolved
@iromeo iromeo self-requested a review July 26, 2021 16:35
@iromeo iromeo assigned dakochik and unassigned iromeo Jul 26, 2021
fixed: separate sections for workflow keywords are created, SmkSyntax…
b9081f6 
…ErrorAnnotator highlighting is fixed

Resolves: #384
@dakochik
Copy link
Contributor Author

fixed: highlighting for SmkSyntaxErrorAnnotator
refactored: separate sections for workflows keywords are created

@dakochik dakochik assigned iromeo and unassigned dakochik Jul 27, 2021
@iromeo iromeo merged commit b3588f2 into master Jul 27, 2021
@iromeo iromeo deleted the features/#384-top-level-inspections branch July 27, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iromeo iromeo Awaiting requested review from iromeo

Assignees

@iromeo iromeo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakochik @iromeo