Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expected collections.iterable but got output: false positive #317

Closed
iromeo opened this issue Sep 7, 2020 · 1 comment
Closed

Expected collections.iterable but got output: false positive #317

iromeo opened this issue Sep 7, 2020 · 1 comment
Assignees
@iromeo
Labels
3rd party bug Something isn't working codeInsight Code completion, resolve inspections Code inspections
Milestone
0.9.0

Comments

@iromeo
Copy link
Contributor

iromeo commented Sep 7, 2020

It is PyCharm PyTypeChecker related inspection, doesn't work correctly in snakemake code

image
@iromeo iromeo added this to the 0.8.x milestone Sep 7, 2020
@iromeo iromeo self-assigned this Sep 7, 2020
@iromeo iromeo added 3rd party codeInsight Code completion, resolve inspections Code inspections bug Something isn't working labels Sep 7, 2020
@iromeo
Copy link
Contributor Author

iromeo commented Sep 7, 2020

com.jetbrains.python.inspections.PyTypeCheckerInspection.Visitor#checkIteratedValue check works via PyABCUtil.isSubtype(type, iterableClassName, this.myTypeEvalContext). If type is PyStructuralType than no FP, some marker interface is required here, because PyStructuralType not very convenient to 'hack`

@iromeo iromeo mentioned this issue Sep 7, 2020
Open
14 tasks
@iromeo iromeo closed this as completed in 4c5b73f Sep 7, 2020
@iromeo iromeo modified the milestones: 0.8.x, 0.8.1 Sep 7, 2020
iromeo added a commit that referenced this issue Sep 7, 2020
@iromeo
fixed: Fix for #317 resolves #320
ff75fd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iromeo iromeo

Labels
3rd party bug Something isn't working codeInsight Code completion, resolve inspections Code inspections
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@iromeo