Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line mover action doesn't work properly for section args #174

Closed
iromeo opened this issue Aug 7, 2019 · 2 comments · Fixed by #303
Closed

Line mover action doesn't work properly for section args #174

iromeo opened this issue Aug 7, 2019 · 2 comments · Fixed by #303
Assignees
@artemd24
Milestone
0.9.0

Comments

@iromeo
Copy link
Contributor

iromeo commented Aug 7, 2019 •
edited
Loading

See LineMover, PyStatementMover classes.

E.g. in code

rule foo:
   input: "ddd"
   output:
       key1="val1",
       key2="val2"

See Code|Move Statement Up/Down actions
@iromeo
Copy link
Contributor Author

iromeo commented Sep 2, 2019

Line mover works ok.
Statements mover should be enhanced. It moves rule inside another rule, which isn't desired.

@iromeo iromeo modified the milestones: Backlog, 0.8.x Jul 3, 2020
@iromeo
Copy link
Contributor Author

iromeo commented Jul 13, 2020 •
edited
Loading

EP: com.intellij.statementUpDownMover

E.g. for python:

   <statementUpDownMover implementation="com.jetbrains.python.codeInsight.editorActions.moveUpDown.PyStatementMover" id="pyStatementMover"
                          order="before line"/>

see com.jetbrains.python.codeInsight.editorActions.moveUpDown.PyStatementMover

Tests: PyStatementMoverTest

@iromeo iromeo modified the milestones: 0.8.x, 0.8.1 Jul 13, 2020
@artemd24 artemd24 mentioned this issue Aug 1, 2020
Merged
iromeo added a commit that referenced this issue Sep 8, 2020
@iromeo
Merge branch 'master' into features/#174-line-mover-action
69568fe
iromeo added a commit that referenced this issue Sep 8, 2020
@artemd24 @iromeo
#174 Line mover for rule sections (#303)
d028c17 
* Add up/down over for rules in *.smk files
* tests cleanup, removed duplicated test data, constant scenario outline variables etc
* impl split in PyStatementMover copy-paste vs changed methods

Co-authored-by: Roman Chernyatchik <[email protected]>
@iromeo iromeo mentioned this issue Sep 8, 2020
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemd24 artemd24

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

#174 Line mover for rule sections JetBrains-Research/snakecharm
2 participants
@iromeo @artemd24