Another view on how tests should like #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I started, I was thinking that this new tests system will be more concise and handy. Maybe it's just the problem in PHP bindings from ControlFlowInstructions to PsiElements but I find it still hard to write tests like that. However it can still be better than the previous solution.
Anyway, for referencing PsiElements I decided to go with the following triple: some text representation of a PsiElement, line number in the source file and column number in the source file where the PsiElement is located.
As a text representation I decided to use the simple PsiElement.toString() method because it's mostly the same content as the PsiViewer shows us. Another advantage is that keeps text short even for structures like
for
orif
.I tried not to add the column number but keep struggling with the corner cases like that:
Here
$i
in$i = 0
and$i
in$i < 2
correspond to 2 different PsiElements (they are both VariableImpls but still). So that's why I find column number necessary.