Preserve dataset structure #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpirinEgor
suggested changes
Aug 6, 2021
configs/antlr_java_js_ast.yaml
Outdated
Comment on lines
24
to
26
| name: code2seq | ||
| length: 9 | ||
| width: 2 |
There was a problem hiding this comment.
Why did you change the config example?
| parsingResultFactory.parseFiles(files) { parseResult -> | ||
| for (labeledResult in branch.process(parseResult)) { | ||
| storage.store(labeledResult) | ||
| for ((holdoutType, holdout) in holdouts) { |
There was a problem hiding this comment.
Let's name it holdoutPath
There was a problem hiding this comment.
But holdout type is File. Maybe holdoutDir?
|
Resolve conflicts, please |
# Conflicts: # src/main/kotlin/astminer/pipeline/Pipeline.kt
SpirinEgor
suggested changes
Aug 6, 2021
Comment on lines
46
to
51
| private fun <T : Closeable, R> T.useSynchronously(callback: (T) -> R) = | ||
| this.use { | ||
| synchronized(this) { | ||
| callback(this) | ||
| } | ||
| } |
There was a problem hiding this comment.
That looks complicated ;)
There was a problem hiding this comment.
Maybe we can add in storage interface syncronizedStore:
fun syncronizedStore(labeledResult: LabeledResult<out Node>) = syncronized {
store(labeledResult)
}
| } | ||
|
|
||
| private fun printHoldoutStat(files: List<File>, holdoutType: DatasetHoldout) { | ||
| var output = "${files.size} file(s) found" |
There was a problem hiding this comment.
You can use StringBuilder for manipulation with strings to avoid using mutable strings
SpirinEgor
approved these changes
Aug 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to recognize dataset structure (folders train, test, val) and recreate their structure in the final output directory.