Pipeline #143
Merged
Pipeline #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/kotlin/astminer/cli/LabelExtractors.kt
# Conflicts: # src/main/kotlin/astminer/cli/LabelExtractors.kt # src/main/kotlin/astminer/common/model/HandlerModel.kt # src/main/kotlin/astminer/examples/Code2VecJavaMethods.kt
# Conflicts: # build.gradle.kts # src/main/kotlin/astminer/parse/antlr/javascript/JavaScriptMethodSplitter.kt # src/test/kotlin/astminer/cli/Code2VecExtractorTest.kt # src/test/kotlin/astminer/cli/PathContextsExtractorTest.kt # src/test/kotlin/astminer/parse/cpp/FuzzyMethodSplitterTest.kt # src/test/kotlin/astminer/parse/gumtree/python/GumTreePythonMethodSplitterTest.kt
# Conflicts: # src/main/kotlin/astminer/cli/Code2VecExtractor.kt # src/main/kotlin/astminer/cli/LabelExtractors.kt # src/main/kotlin/astminer/cli/ProjectParser.kt # src/main/kotlin/astminer/cli/utils.kt # src/main/kotlin/astminer/common/model/HandlerModel.kt # src/main/kotlin/astminer/examples/AllJavaFiles.kt # src/main/kotlin/astminer/examples/Code2VecJavaMethods.kt # src/main/kotlin/astminer/parse/antlr/javascript/JavaScriptMethodSplitter.kt # src/test/kotlin/astminer/cli/LabelExtractorTest.kt
SpirinEgor
suggested changes
May 23, 2021
| private fun createStorage(extension: FileExtension): Storage = with(config.storage) { | ||
| val storagePath = createStorageDirectory(extension).path | ||
|
|
||
| // TODO: should be removed this later and be implemented like filters and problems, once storage constructors have no side effects |
There was a problem hiding this comment.
What side effects do you mention here?
There was a problem hiding this comment.
For example the constructor of CsvAstStorage creates folders on the disk. In this case it is critical because I don't want storageConfig.getStorage() to create directories
src/test/kotlin/astminer/parse/gumtree/python/GumTreePythonMethodSplitterTest.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/kotlin/astminer/cli/FilterPredicates.kt # src/main/kotlin/astminer/cli/LabelExtractors.kt # src/main/kotlin/astminer/cli/ProjectParser.kt # src/main/kotlin/astminer/common/model/ParsingModel.kt # src/test/kotlin/astminer/common/TestUtils.kt
# Conflicts: # src/main/kotlin/astminer/cli/Code2VecExtractor.kt # src/main/kotlin/astminer/cli/FilterPredicates.kt # src/main/kotlin/astminer/cli/LabelExtractors.kt # src/main/kotlin/astminer/cli/PathContextsExtractor.kt # src/main/kotlin/astminer/cli/ProjectParser.kt # src/main/kotlin/astminer/common/model/ParsingModel.kt # src/main/kotlin/astminer/examples/AllJavaScriptFiles.kt # src/main/kotlin/astminer/examples/AllPythonFiles.kt # src/test/kotlin/astminer/cli/LabelExtractorTest.kt
SpirinEgor
suggested changes
May 25, 2021
There was a problem hiding this comment.
- Please rename config extensions. YML corresponds to "Yandex Market Language" and in configs, we use "YAML Ain't Markup Language" or simply YAML.
- Also, I don't get how you name those configs. I expect more understandable names, like
function-name-prediction-path-representation.yamlorfile-asts-csv-storage.yaml - Create a
branchpackage inside thepipelinepackage. And move both branches to separate files in this package. I guess storing them all in one file leads to less readability.
SpirinEgor
suggested changes
May 31, 2021
src/main/kotlin/astminer/pipeline/branch/FunctionPipelineBranch.kt
Outdated
Show resolved
Hide resolved
SpirinEgor
suggested changes
May 31, 2021
SpirinEgor
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely replaces old CLI with new pipeline and config