Render uncompilable test suite if it was successfully parsed #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vladislav0Art
commented
Sep 27, 2024
| @@ -23,14 +21,10 @@ data class TestGenerationData( | |||
| // changing parameters with a large prompt | |||
| var polyDepthReducing: Int = 0, | |||
| var inputParamsDepthReducing: Int = 0, | |||
|
|
|||
| // list of correct test cases during the incorrect compilation | |||
| val compilableTestCases: MutableSet<TestCaseGeneratedByLLM> = mutableSetOf(), | |||
There was a problem hiding this comment.
I removed this variable because we never used its value (only wrote in it); test cases that are rendered in the sidebar are taken from Report.testCaseList variable.
Vladislav0Art
commented
Sep 27, 2024
Hello-zoka
requested changes
Sep 27, 2024
...src/main/kotlin/org/jetbrains/research/testspark/core/generation/llm/LLMWithFeedbackCycle.kt
Show resolved
Hide resolved
arksap2002
approved these changes
Sep 30, 2024
…ationData.compilableTestCases` field `TestGenerationData.compilableTestCases` was only used to store test cases. These stored tests were never used afterward, due to `Report`'s `testCaseList`, from which all tests were retrieved for render. Authored-By: Vladislav Artiukhov
…GENERATED` result code
Vladislav0Art
force-pushed
the
vartiukhov/feature/show-parsable-test-suite
branch
from
280dfc9 to
e2039b0
Compare
Hello-zoka
approved these changes
Oct 3, 2024
arksap2002
pushed a commit
to edwin1729/TestSpark
that referenced
this pull request
Jan 10, 2025
…ns-Research#370) * feat: render parsable but uncompilable test cases & remove `TestGenerationData.compilableTestCases` field `TestGenerationData.compilableTestCases` was only used to store test cases. These stored tests were never used afterward due to `Report`'s `testCaseList`, from which all tests were retrieved for render. Authored-By: Vladislav Artiukhov * feat: generate Javadoc comments for `Report` via AI * fix: apply ktlint * fix: `PromptManager`'s javadoc minor change * feat: check that test suite is present for `NO_COMPILABLE_TEST_CASES_GENERATED` result code * publish: core version `3.0.1` * fix: apply ktlint --------- Co-authored-by: Vladislav Artiukhov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes made
See the rationale in Render uncompilable test suite if it was successfully parsed #312.
TestGenerationData.compilableTestCasesmember field because it was never read (we only wrote compilable test cases into it); test cases that are rendered in the sidebar tab are read fromReportinstance (see the use ofLLMWithFeedbackCycle.recordReportfunction).Why is a merge request needed
It improves UX of LLM-based test generation for complex CUTs.
Other notes
Closes #312
You may test the implementation on
PromptManagerclass; it's complex enough.Undone
Does it affect headless mode in any sense?