Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid escape sequence in regex #365

Merged

Conversation

syusuke9999
Copy link
Contributor

Updated the regex in pandoc_download.py to correctly escape the period character. This change resolves the SyntaxWarning triggered by an invalid escape sequence and ensures compatibility with future Python versions.

Updated the regex in pandoc_download.py to correctly escape the period character.
This change resolves the SyntaxWarning triggered by an invalid escape sequence and ensures compatibility with future Python versions.
@JessicaTegner
Copy link
Owner

@syusuke9999 it seems that this change breaks the download pandoc functionality in the CI pipeline. Could you take a look at this

Adjusted the regex to fix URL matching issues identified during CI tests, ensuring effective Pandoc downloads.
@syusuke9999
Copy link
Contributor Author

Thanks for the feedback, @JessicaTegner. I've adjusted the regex to fix the CI download issues and verified that it now works as intended. Please review the changes at your convenience.

@JessicaTegner
Copy link
Owner

@syusuke9999 seems good to me. Thank you so much for the pr :)

@JessicaTegner JessicaTegner merged commit 06d0134 into JessicaTegner:master Jun 4, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants