Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task and Server returned seperately #135

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Task and Server returned seperately #135

merged 2 commits into from
Jun 10, 2024

Conversation

Jerboa-app
Copy link
Contributor

Task::run now does not spawn a thread so it can be aborted

Closes #134

Task::run now does not spawn a thread so it can be aborted
@BurrowBot
Copy link

Seems the coverage is below main by -0.3 %, please consider adding to the tests, thanks!
Here is the full report breakdown

Total coverage 57.6 % (-0.3 % against main)
________________________________
src/main.rs                      | 0.0   % 0 / 67
src/server/api/stats.rs          | 0.0   % 0 / 78
src/server/http.rs               | 0.0   % 0 / 20
src/server/https.rs              | 5.88  % 4 / 68
src/server/stats/mod.rs          | 30.36 % 17 / 56
src/integrations/git/refresh.rs  | 30.91 % 17 / 55
src/lib.rs                       | 42.11 % 8 / 19
src/server/stats/hits.rs         | 45.68 % 37 / 81
src/integrations/github/mod.rs   | 55.13 % 43 / 78
src/server/throttle.rs           | 61.22 % 30 / 49
src/integrations/discord/post.rs | 62.5  % 10 / 16
src/server/stats/digest.rs       | 69.66 % 62 / 89
src/filesystem/folder.rs         | 71.11 % 32 / 45
src/task/mod.rs                  | 71.93 % 41 / 57
src/content/mod.rs               | 72.48 % 79 / 109
src/integrations/git/mod.rs      | 74.77 % 83 / 111
src/integrations/mod.rs          | 76.47 % 26 / 34
src/content/sitemap.rs           | 77.49 % 148 / 191
src/server/stats/file.rs         | 79.31 % 23 / 29
src/filesystem/file.rs           | 79.41 % 27 / 34
src/filesystem/mod.rs            | 80.0  % 8 / 10
src/util.rs                      | 82.76 % 72 / 87
src/config.rs                    | 92.11 % 35 / 38
src/content/filter.rs            | 100.0 % 5 / 5
src/content/mime_type.rs         | 100.0 % 31 / 31
src/integrations/webhook.rs      | 100.0 % 3 / 3
________________________________

@BurrowBot
Copy link

Looks like you increased coverage by 1.48 %, fantastic!
Here is the full report breakdown

Total coverage 59.38 % (+1.48 % against main)
________________________________
src/main.rs                      | 0.0   % 0 / 67
src/server/api/stats.rs          | 0.0   % 0 / 78
src/server/http.rs               | 0.0   % 0 / 20
src/server/https.rs              | 5.88  % 4 / 68
src/server/stats/mod.rs          | 30.36 % 17 / 56
src/integrations/git/refresh.rs  | 30.91 % 17 / 55
src/lib.rs                       | 42.11 % 8 / 19
src/server/stats/hits.rs         | 45.68 % 37 / 81
src/integrations/github/mod.rs   | 55.13 % 43 / 78
src/server/throttle.rs           | 61.22 % 30 / 49
src/filesystem/folder.rs         | 71.11 % 32 / 45
src/task/mod.rs                  | 71.93 % 41 / 57
src/content/mod.rs               | 72.48 % 79 / 109
src/integrations/git/mod.rs      | 74.77 % 83 / 111
src/integrations/mod.rs          | 76.47 % 26 / 34
src/content/sitemap.rs           | 77.49 % 148 / 191
src/server/stats/file.rs         | 79.31 % 23 / 29
src/filesystem/file.rs           | 79.41 % 27 / 34
src/filesystem/mod.rs            | 80.0  % 8 / 10
src/util.rs                      | 82.76 % 72 / 87
src/config.rs                    | 92.11 % 35 / 38
src/server/stats/digest.rs       | 93.26 % 83 / 89
src/integrations/discord/post.rs | 93.75 % 15 / 16
src/content/filter.rs            | 100.0 % 5 / 5
src/content/mime_type.rs         | 100.0 % 31 / 31
src/integrations/webhook.rs      | 100.0 % 3 / 3
________________________________

@Jerboa-app Jerboa-app merged commit 0a5f5e1 into main Jun 10, 2024
6 checks passed
@Jerboa-app Jerboa-app deleted the fix_134 branch June 29, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TaskPool is leaked
2 participants