Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dedicated error type for FromStr (#221) #235

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Use dedicated error type for FromStr (#221) #235

merged 2 commits into from
Jan 26, 2023

Conversation

tyranron
Copy link
Collaborator

Part of #221
Resolves #221

Synopsis

#221 (comment)

Solution

Adds FromStrError type and uses it in #[derive(FromStr)] expansion for enums instead of generating an error type in-place.

Checklist

  • Documentation is updated (if required)
  • Tests are added/updated (if required)
  • CHANGELOG entry is added (if required)

@tyranron tyranron added this to the 1.0.0 milestone Jan 26, 2023
@tyranron tyranron self-assigned this Jan 26, 2023
@tyranron tyranron requested a review from JelteF January 26, 2023 15:09
@JelteF JelteF merged commit 9014b18 into master Jan 26, 2023
@JelteF JelteF deleted the 221-fromstr-error-type branch January 26, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelteF JelteF JelteF approved these changes

Assignees

@tyranron tyranron

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Use dedicated error type for errors returned by Add, Not and FromStr
2 participants
@tyranron @JelteF