display: enum match arms: use 'Self' (to fix incompatibility with #![deny(clippy::use_self)]
#192
Conversation
|
@phip1611 well, this change doesn't survive the MSRV check. @JelteF are we OK to bump up MSRV to at least 1.51 (last 10 versions)? Or do you see some sense to keep MSRV such outdated? |
|
btw, I fixed the latest (unrelated) clippy error as well. |
|
I am not opposed to bumping MSRV to something less ancient, but I would like to do that only when increasing the major version of the library. Marking this lib as 1.0 is way overdue anyway. I cleaned up the 1.0.0 milestone to only contain things that require breaking changes, it turned out that was only a single thing. |
|
@JelteF in case we don't want to do |
|
@phip1611 bumping MSRV is OK, as we're going to release 1.0.0. |
phip1611
force-pushed
the
use-self-instead-of-enum-name
branch
from
abbaee9
to
c9f8a2b
Compare
|
I rebased the MR onto the latest master. Can you approve the CI, please? |
Revealed from #192 (comment) ## Synopsis The code, generated by `derive_more`, often becomes a subject of complains for strict style linters. ## Solution Use `#[automatically_derived]` attribute on any generated code, so the code style linters will omit the generated code.
Revealed from JelteF/derive_more#192 (comment) ## Synopsis The code, generated by `derive_more`, often becomes a subject of complains for strict style linters. ## Solution Use `#[automatically_derived]` attribute on any generated code, so the code style linters will omit the generated code.
This PR makes the generated code compatible with a global setting of
#![deny(clippy::use_self)]by usingSelf::Variantinstead ofEnumName::Variant.