Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse twig_inst. #15

Merged

Conversation

Daylily-Zeleen
Copy link
Contributor

@JekSun97 I received your email and create this pr to solve your problem.

Fix #1.

Like I said in #9282.
Just reuse the internal node instead of removing it and adding a new one.

By the way, this is greate plugin!

@Daylily-Zeleen Daylily-Zeleen changed the title Use only one twig_inst instead of new an new one when parameters chan… Reuse twig_inst. Nov 11, 2024
@FibreFoX
Copy link
Contributor

So this PR solves multiple issues, right?

@Daylily-Zeleen
Copy link
Contributor Author

So this PR solves multiple issues, right?

I dont know, I am invited to sovle #1 only.

@JekSun97
Copy link
Owner

@Daylily-Zeleen Wow, I didn't think that the response to help would be so fast!
After looking at the changes in the code, I realized that I still have to delve into the knowledge of godot-cpp, thank you very much, this error has greatly disrupted the progress of the plugin, I will check everything at home and post it ^_^

@JekSun97 JekSun97 merged commit d718544 into JekSun97:main Nov 11, 2024
@JekSun97
Copy link
Owner

@Daylily-Zeleen Strange, the duplication error still persists:

1112.mp4

@Daylily-Zeleen
Copy link
Contributor Author

@JekSun97 Refer to my comment, this solution need some commits of godot and godot-cpp.
They are merged in 4.3, in orthor words, this pr will require this plugin to use at least godot 4.3 both godot and godot-cpp.

@JekSun97
Copy link
Owner

@JekSun97 Refer to my comment, this solution need some commits of godot and godot-cpp. They are merged in 4.3, in orthor words, this pr will require this plugin to use at least godot 4.3 both godot and godot-cpp.

Got it, unfortunately then I'll have to reduce the minimum supported version of Godot

@FibreFoX
Copy link
Contributor

@JekSun97 what is your plan on the version? as far as I understand, this issue is in combination with Godot itself, right? Should #1 then be reopened then, because the issue isnt solved for earlier versions?

@Daylily-Zeleen do you know if there is any backport earlier than godot 4.3 ?

@Daylily-Zeleen Daylily-Zeleen deleted the daylily-zeleen/fix-duplicate-issue branch November 13, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplication problem
3 participants