[Deployment] Add secure=false explicitly in manifests for better obse…

…rvability (kubeflow#3217) * Revert "Revert "minio: Set secure=true to enable TLS by default (kubeflow#3168)" (kubeflow#3192)" This reverts commit 743746b. * Fix managed storage specific manifest * Update pipeline.yaml * Update client_manager.go
Jeffwan · Dec 9, 2020 · faa768a · faa768a
1 parent 38a8e1a
commit faa768a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/manifests/gcp_marketplace/chart/kubeflow-pipelines/templates/pipeline.yaml b/manifests/gcp_marketplace/chart/kubeflow-pipelines/templates/pipeline.yaml
@@ -662,6 +662,8 @@ spec:
                   fieldPath: metadata.namespace
             - name: DEFAULTPIPELINERUNNERSERVICEACCOUNT
               value: 'pipeline-runner'
+            - name: OBJECTSTORECONFIG_SECURE
+              value: "false"
             # Following environment variables are only needed when using Cloud SQL and GCS.
             {{ if .Values.managedstorage.enabled }}
             - name: OBJECTSTORECONFIG_BUCKETNAME

diff --git a/manifests/kustomize/base/pipeline/ml-pipeline-apiserver-deployment.yaml b/manifests/kustomize/base/pipeline/ml-pipeline-apiserver-deployment.yaml
@@ -19,6 +19,8 @@ spec:
           valueFrom:
             fieldRef:
               fieldPath: metadata.namespace
+        - name: OBJECTSTORECONFIG_SECURE
+          value: "false"
         image: gcr.io/ml-pipeline/api-server:0.1.27
         imagePullPolicy: IfNotPresent
         name: ml-pipeline-api-server