Clusterrolebinding is using namespace which not parametrized (kubeflo…

…w#3573) submit quick to make sure others won't got confused
Jeffwan · Dec 9, 2020 · 38ad8aa · 38ad8aa
1 parent 7067dcf
commit 38ad8aa
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 9 deletions.
diff --git a/...fests/kustomize/base/cache-deployer/cluster-scoped/cache-deployer-clusterrolebinding.yaml b/...fests/kustomize/base/cache-deployer/cluster-scoped/cache-deployer-clusterrolebinding.yaml
@@ -9,4 +9,5 @@ roleRef:
 subjects:
 - kind: ServiceAccount
   name: kubeflow-pipelines-cache-deployer-sa
+  # Here it should be changed or overwrite to well match with customized namespace
   namespace: kubeflow
diff --git a/manifests/kustomize/env/dev/kustomization.yaml b/manifests/kustomize/env/dev/kustomization.yaml
@@ -11,5 +11,6 @@ bases:
 commonLabels:
   application-crd-id: kubeflow-pipelines
 
-# Replace with your namespace
+# !!! If you want to customize the namespace,
+# please also update base/cache-deployer/cluster-scoped/cache-deployer-clusterrolebinding.yaml
 namespace: kubeflow
diff --git a/manifests/kustomize/env/gcp/kustomization.yaml b/manifests/kustomize/env/gcp/kustomization.yaml
@@ -14,7 +14,8 @@ bases:
 commonLabels:
   application-crd-id: kubeflow-pipelines
 
-# Replace with your namespace
+# !!! If you want to customize the namespace,
+# please also update base/cache-deployer/cluster-scoped/cache-deployer-clusterrolebinding.yaml
 namespace: kubeflow
 
 patchesStrategicMerge:

diff --git a/manifests/kustomize/env/platform-agnostic/kustomization.yaml b/manifests/kustomize/env/platform-agnostic/kustomization.yaml
@@ -12,7 +12,8 @@ bases:
 commonLabels:
   application-crd-id: kubeflow-pipelines
 
-# Replace with your namespace
+# !!! If you want to customize the namespace,
+# please also update base/cache-deployer/cluster-scoped/cache-deployer-clusterrolebinding.yaml
 namespace: kubeflow
 
 images:

diff --git a/manifests/kustomize/sample/README.md b/manifests/kustomize/sample/README.md
@@ -64,7 +64,7 @@ kubectl apply -k sample/
 # If upper one action got failed, e.x. you used wrong value, try delete, fix and apply again
 # kubectl delete -k sample/
 
-kubectl wait applications/mypipeline -n mykubeflow --for condition=Ready --timeout=1800s
+kubectl wait applications/mypipeline -n kubeflow --for condition=Ready --timeout=1800s
 ```
 
 Now you can find the installation in [Console](http://console.cloud.google.com/ai-platform/pipelines)

diff --git a/manifests/kustomize/sample/kustomization.yaml b/manifests/kustomize/sample/kustomization.yaml
@@ -16,10 +16,12 @@ secretGenerator:
     env: params-db-secret.env
     behavior: merge
 
+# !!! If you want to customize the namespace,
+# please also update base/cache-deployer/cluster-scoped/cache-deployer-clusterrolebinding.yaml
+namespace: kubeflow
+
 #### Customization ###
-# 1. Replace with your namespace
-namespace: mykubeflow
-# 2. Change values in params.env file
-# 3. Change values in params-db-secret.env file for CloudSQL username and password
-# 4. kubectl apply -k ./
+# 1. Change values in params.env file
+# 2. Change values in params-db-secret.env file for CloudSQL username and password
+# 3. kubectl apply -k ./
 ####