Add linter and CI #104
Merged
Add linter and CI #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaitodor
force-pushed
the
add-linter
branch
2 times, most recently
from
b119c15 to
beb3983
Compare
mihaitodor
force-pushed
the
add-linter
branch
from
beb3983 to
98c0048
Compare
|
HERE I AM ACKNOWLEDGING THAT THIS REPO EXISTS 🥳 Thanks @mihaitodor, sorry for the delay 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought to add some linting and CI to this one too.
I guess 93f81fa might have caused trouble in some cases, because the underlying data of slices is passed by reference.On second thought, after playing with some similar code a bit, I think the compiler is smart enough to do the right thing. I can revert to the original implementation and add a linter exception if you prefer that.Also, there are a bunch of functions called in the tests which aren't checked for errors and I ignored them for now. Happy to add those checks if you don't mind the extra verbosity.