Fixed the logic to check for SideKickButton in the Core db #16
Conversation
| @@ -69,7 +69,7 @@ public static void EnsureDesktopButton() | |||
| return; | |||
|
|
|||
| Item sk = core.GetItem(new ID(SidekickButton)); | |||
| if (sk != null) | |||
| if (sk == null) | |||
There was a problem hiding this comment.
This change would make it so if the sidekick button doesn't exist yet it breaks out of the method thus not creating the button. Are you tracking a particular bug related to this?
There was a problem hiding this comment.
I wasn't seeing the SideKick button on the Desktop right menu. I checked and the Core db had all the items refrenced by the fields of this class, which led me to this change, after which button appeared.
There was a problem hiding this comment.
So, the logic here is that if the button definition already exists then return out of the method. If sk is not null, that means it's already defined and we can skip the rest of the check. The change you have here makes it so a fresh install of sidekick would skip adding the button if the button doesn't exist.
You can confirm this by trying it on a fresh Sitecore install from SIM
|
I think this is resolved now, haven't had this issue on the latest version, but I did on an older version. |
Fixed the logic which was preventing the SideKick button being shown in the Desktop menu.
Returning if SitecoreSideKick button is null.