Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE11 issue where focus is lost when scrolling through options #849

Merged
merged 1 commit into from
Apr 19, 2016

Conversation

elijahmanor
Copy link
Contributor

This PR fixes issue #848 and the following animated gif shows the fix in action...

bruc7pz2bb-after

You can read more about the details of the bug in the related #848 issue and watch the broken behavior there (animated gif)

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling cca70cf on elijahmanor:fix-ie11-focus into * on JedWatson:master*.

@jstcki
Copy link

jstcki commented Mar 29, 2016

I ran into the same issue, and this worked.

Maybe you could use this.focus() instead of this.refs.input.focus(), since that's used throughout the rest of the component.

@elijahmanor
Copy link
Contributor Author

@herrstucki good catch! i'll update the code and make sure the behavior still works and the tests pass.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f6fa779 on elijahmanor:fix-ie11-focus into * on JedWatson:master*.

@elijahmanor
Copy link
Contributor Author

@herrstucki I made the update to use this.focus and all tests still pass and the behavior is still as intended. Thanks for the suggestion

@HenriJ
Copy link

HenriJ commented Apr 18, 2016

We still encounter this bug with IE (11). This PR seems to fix this issue. Please merge it when possible :)

@JedWatson JedWatson merged commit f6fa779 into JedWatson:master Apr 19, 2016
@JedWatson
Copy link
Owner

Thanks @elijahmanor! Merged it, will publish a new release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants