Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed console error in GitHub users example #2244

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Fixed console error in GitHub users example #2244

merged 1 commit into from
Jan 4, 2018

Conversation

yuri-sakharov
Copy link
Contributor

Appears error after clicking on "Creatable?" checkbox in GitHub users (Async with fetch.js) example.

The error:
app.js:323 Warning: GithubUsers is changing an uncontrolled input of type checkbox to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.118% when pulling 2823b81 on yuri-sakharov:fix/console-error-in-example into d2a3afd on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 94.126% when pulling 2823b81 on yuri-sakharov:fix/console-error-in-example into d2a3afd on JedWatson:master.

@JedWatson
Copy link
Owner

Thanks for catching that @yuri-sakharov

@JedWatson JedWatson merged commit f2aefff into JedWatson:master Jan 4, 2018
@yuri-sakharov yuri-sakharov deleted the fix/console-error-in-example branch January 4, 2018 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants