Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Select.js refactor #2234

Merged
merged 9 commits into from
Jan 5, 2018
Merged

Minor Select.js refactor #2234

merged 9 commits into from
Jan 5, 2018

Conversation

yuri-sakharov
Copy link
Contributor

@yuri-sakharov yuri-sakharov commented Dec 19, 2017

Select.js code is inconsistent, some times uses var, some times const, let. Present unused prop. 2 methods I moved outside of the class and alphabetically order.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.134% when pulling 9e003b7 on yuri-sakharov:refactor/select-1 into d2a3afd on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.134% when pulling b09afb9 on yuri-sakharov:refactor/select-1 into d2a3afd on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.142% when pulling 8a5689f on yuri-sakharov:refactor/select-1 into d2a3afd on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.142% when pulling bb8e7b0 on yuri-sakharov:refactor/select-1 into d2a3afd on JedWatson:master.

@JedWatson JedWatson changed the base branch from master to 2234-refactor January 5, 2018 04:12
@JedWatson JedWatson merged commit 6f52559 into JedWatson:2234-refactor Jan 5, 2018
@yuri-sakharov yuri-sakharov deleted the refactor/select-1 branch January 5, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants