Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeSelected: bool #2024

Closed
wants to merge 1 commit into from
Closed

removeSelected: bool #2024

wants to merge 1 commit into from

Conversation

firedev
Copy link

@firedev firedev commented Sep 27, 2017

When removeSelected is set to false you can add same item multiple
times

Changed removal logic to remove values based on position

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.368% when pulling 0ad0471 on firedev:removeSelected into 7523c20 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.368% when pulling 0ad0471 on firedev:removeSelected into 7523c20 on JedWatson:master.

@firedev
removeSelected: bool
430bf2c 
When `removeSelected` is set to `false` you can add same item multiple
times

Changed removal logic to remove values based on position
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.368% when pulling 430bf2c on firedev:removeSelected into 7523c20 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 92.368% when pulling 430bf2c on firedev:removeSelected into 7523c20 on JedWatson:master.

@gwyneplaine
Copy link
Collaborator

Thanks for this @firedev, we've opted with a removeSelected PR that's more generic. Please see the following PR. #1891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@firedev @coveralls @gwyneplaine