Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Webpack 2, Webpack 3, rollup. #2020

Merged
merged 1 commit into from
Sep 24, 2017
Merged

Conversation

mschnee
Copy link
Contributor

@mschnee mschnee commented Sep 22, 2017

Current LTS versions of Webpack and Node honor the standardized module field in the package.json. As I am using webpack 3 and was confused when it wasn't resolving your awesome optimized dist builds, I decided to PR the fix for y'all (and leave the old jsnext:main as there are plenty of systems that still use it)

Current LTS versions of Webpack and Node honor the standardized `module` field in the `package.json`.  As I am using webpack 3 and was confused when it wasn't resolving your awesome optimized dist builds, I decided to PR it for y'all.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.344% when pulling 049bff1 on mschnee:master into eb2dfba on JedWatson:master.

@JedWatson
Copy link
Owner

Thanks for picking that up @mschnee!

@JedWatson JedWatson merged commit 105275b into JedWatson:master Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants