-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variable for focused input background #1998
Conversation
a218808
to
ffe5b12
Compare
Thanks @aronstrandberg, happy to accept this addition. Would you please add it to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix this up and add the .scss files as well, as we can merge this 👍
less/select.less
Outdated
@@ -15,6 +15,7 @@ | |||
// control options | |||
@select-input-bg: #fff; | |||
@select-input-bg-disabled: #f9f9f9; | |||
@select-input-bg-focus: #fff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this default to @select-input-bg
in case that has been customised, otherwise this would be a breaking change.
@JedWatson Pushed some commits to adress these things. I couldn't find the equivalent of |
Adds a variable to make it possible to configure the input's background color when focused
2fdedda
to
535bc23
Compare
@JedWatson I just rebased this on master to adjust for upstream changes. Do you think this is ready to merge? |
Looks great @aronstrandberg, thanks! |
Do not release feature with big bug :
|
Add a variable to make it possible to configure the input's background color when focused.
I was trying to theme the focused state in a project, but found it bit cumbersome, hence the desire for these changes. I'd be happy to make any requested changes from your side.