implemented optional rendering of arrow #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implements requested feature of #1700 |
…ith conditional rendering of loading indicator and clear button
yih-en
added a commit
to GovWizely/zAPIness-search-widget
that referenced
this pull request
Jun 20, 2017
- The style will be removed once JedWatson/react-select#1761 is merged to master
|
Is this PR going to be considered, 👍 on the request 😄 . |
|
@Uelb I'm afraid I don't understand. Despite that, I'm slightly confused in how PRs will be accepted as there are a bunch of open ones. |
|
Hi, guys, is that PR gonna be merged? |
|
Sorry for the delay here - we've had another PR to do similar functionality ( |
|
Realised this PR includes updates to the less, docs and tests that weren't already present so I've resolved conflicts and merged it. Thanks @rolandjohann! |
ls-endurance
added a commit
to ls-endurance/DefinitelyTyped
that referenced
this pull request
Jul 16, 2018
In this issue, arrow rendering would keep the functionality even if no arrow was being rendered. The PR below fixed the issue. JedWatson/react-select#1761 In this PR, the guys added the ability to set the arrowRenderer option to null, which disables all arrow related operation. The types repo needs to reflect this change. Thanks!
9 tasks
sheetalkamat
pushed a commit
to DefinitelyTyped/DefinitelyTyped
that referenced
this pull request
Jul 30, 2018
… null (#27342) * Add ability for arrow renderer prop to be set to null In this issue, arrow rendering would keep the functionality even if no arrow was being rendered. The PR below fixed the issue. JedWatson/react-select#1761 In this PR, the guys added the ability to set the arrowRenderer option to null, which disables all arrow related operation. The types repo needs to reflect this change. Thanks! * Add my name to list
briandk
pushed a commit
to briandk/DefinitelyTyped
that referenced
this pull request
Aug 7, 2018
… null (DefinitelyTyped#27342) * Add ability for arrow renderer prop to be set to null In this issue, arrow rendering would keep the functionality even if no arrow was being rendered. The PR below fixed the issue. JedWatson/react-select#1761 In this PR, the guys added the ability to set the arrowRenderer option to null, which disables all arrow related operation. The types repo needs to reflect this change. Thanks! * Add my name to list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the ability to not render the arrow button by setting prop
arrowRenderertonull. As the arrow element is responsible for the right padding a new less class has been introduced that will add right padding to the last element of the select control.