handle error in creatable multi select text input with bakspace and c…

…hange test case
JedWatson · Jun 30, 2019 · 7640d87 · 7640d87
1 parent e6e09e9
commit 7640d87
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/react-select/src/Select.js b/packages/react-select/src/Select.js
@@ -698,7 +698,7 @@ export default class Select extends Component<Props, State> {
         value: lastSelectedValue ? this.getOptionLabel(lastSelectedValue) : '',
       },
     });
-    this.onChange(newValue.length ? newValue : null, {
+    this.onChange(newValue.length ? newValue : [], {
       action: 'pop-value',
       removedValue: lastSelectedValue,
     });

diff --git a/packages/react-select/src/__tests__/Select.test.js b/packages/react-select/src/__tests__/Select.test.js
@@ -1492,7 +1492,7 @@ test('should not call onChange on hitting backspace even when backspaceRemovesVa
   expect(onChangeSpy).not.toHaveBeenCalled();
 });
 
-cases('should call onChange with `null` on hitting backspace when backspaceRemovesValue is true', ({ props = { ...BASIC_PROPS }, expectedValue }) => {
+cases('should call onChange with `null` on hitting backspace when backspaceRemovesValue is true', ({ props = { ...BASIC_PROPS } }) => {
   let onChangeSpy = jest.fn();
   let selectWrapper = mount(
     <Select
@@ -1505,7 +1505,7 @@ cases('should call onChange with `null` on hitting backspace when backspaceRemov
   selectWrapper
     .find(Control)
     .simulate('keyDown', { keyCode: 8, key: 'Backspace' });
-  expect(onChangeSpy).toHaveBeenCalledWith(null, expectedValue);
+  expect(onChangeSpy).toHaveBeenCalledWith();
 }, {
   'and isMulti is false': {
     props: {