Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Univeristy model #83

Merged
merged 12 commits into from
Sep 16, 2023
Merged

Univeristy model #83

merged 12 commits into from
Sep 16, 2023

Conversation

KingPhilip14
Copy link
Collaborator

No description provided.

@KingPhilip14
3 New Files
d92b283 
Made GroupRun, TeamType, and University model files
@KingPhilip14
Added nullables
bbc3086 
Added nullables to existing files
@KingPhilip14
Added unique
6538cf6 
Added the unique constraint to team_type_name and uni_name.
@KingPhilip14
New things
0704ebe 
Added some new files and foreign keys.
@KingPhilip14
Added new files
43575f8 
Added errors and turn table files.
@KingPhilip14
Fixes
dda6748 
Added fixes to all the files as needed.
MoodyMan04
MoodyMan04 previously approved these changes Sep 9, 2023
View reviewed changes
Copy link
Collaborator

@MoodyMan04 MoodyMan04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be fine!

JeanAEckelberg
JeanAEckelberg requested changes Sep 9, 2023
View reviewed changes
Copy link
Owner

@JeanAEckelberg JeanAEckelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so I did some more digging, fastAPI does not support composite primary keys currently. We will need id's on all of the ones that are composite. This is entirely my fault. Thank you for your patience

@JeanAEckelberg JeanAEckelberg added the Byte Server This issue is for the Byte Server label Sep 16, 2023
@JeanAEckelberg JeanAEckelberg added this to the Update Byte Server milestone Sep 16, 2023
@JeanAEckelberg JeanAEckelberg self-requested a review September 16, 2023 02:12
JeanAEckelberg
JeanAEckelberg previously approved these changes Sep 16, 2023
View reviewed changes
Copy link
Owner

@JeanAEckelberg JeanAEckelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KingPhilip14
Small fix
b6e93aa 
Added Integer() to the primary key of the run file.
@KingPhilip14
Merge branch 'univeristy-model' of https://github.com/JeanAEckelberg/…
997db13 
…byte_engine into univeristy-model
@KingPhilip14
Fixed
48b5cc6 
Fixed more Integer() that was missing.
MoodyMan04
MoodyMan04 approved these changes Sep 16, 2023
View reviewed changes
Copy link
Collaborator

@MoodyMan04 MoodyMan04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good server implementation

JeanAEckelberg
JeanAEckelberg approved these changes Sep 16, 2023
View reviewed changes
Copy link
Owner

@JeanAEckelberg JeanAEckelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JuliaCaesar JuliaCaesar merged commit a8fe6ee into server Sep 16, 2023
@JuliaCaesar JuliaCaesar deleted the univeristy-model branch September 16, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoodyMan04 MoodyMan04 MoodyMan04 approved these changes

@JeanAEckelberg JeanAEckelberg JeanAEckelberg approved these changes

@CarseKeeper CarseKeeper Awaiting requested review from CarseKeeper

Assignees

@JuliaCaesar JuliaCaesar

Labels
Byte Server This issue is for the Byte Server
Projects
None yet
Milestone
Update Byte Server
Development

Successfully merging this pull request may close these issues.
4 participants
@KingPhilip14 @JeanAEckelberg @MoodyMan04 @JuliaCaesar