Created Generic Item #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created the generic Item class, added value errors for illegal assignments
JeanAEckelberg
requested review from
ESatrom,
JuliaCaesar,
KingPhilip14 and
MoodyMan04
ESatrom
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
Looks good, my only comment is I'm not sure if we should be fixing durability to 0-1. If someone doesn't understand it's a percent they may end up with odd behavior and not understand why.
Additionally, it could be worthwhile to make a comment as to what an Item is.
MoodyMan04
approved these changes
Feb 24, 2023
Changed durability to an int and removed bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the generic Item class, added value errors for illegal assignments