Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item inventory features #21

Merged
merged 13 commits into from
Apr 15, 2023
Merged

Item inventory features #21

merged 13 commits into from
Apr 15, 2023

Conversation

KingPhilip14
Copy link
Collaborator

There may be problems in the controller file. I looked at the others for guidance, but let me know if I missed a specific feature for it.

Added documentation and implementation for the inventory for the avatar class. Added appropriate enums and item implementation.
Added an inventory controller that allows the player to select an item from their inventory and set that to be the held item
Copy link
Collaborator

@ESatrom ESatrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only potential issues are minor typing things, and even those I'm not 100% sure on. Looks good.

game/common/avatar.py Outdated Show resolved Hide resolved
game/common/items/item.py Outdated Show resolved Hide resolved
game/common/items/item.py Outdated Show resolved Hide resolved
game/common/items/item.py Outdated Show resolved Hide resolved
Copy link
Owner

@JeanAEckelberg JeanAEckelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

game/common/items/item.py Show resolved Hide resolved
game/common/items/item.py Outdated Show resolved Hide resolved
game/common/items/item.py Show resolved Hide resolved
Made the changes wanted.
I fixed more type hinting
These files should be good now.
Trying to fix issues...
I'm trying.
.
.
.
.
Fixed issues.
@KingPhilip14 KingPhilip14 requested a review from ESatrom April 13, 2023 22:14
Copy link
Collaborator

@ESatrom ESatrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good

Copy link
Owner

@JeanAEckelberg JeanAEckelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz change

game/controllers/inventory_controller.py Outdated Show resolved Hide resolved
game/controllers/inventory_controller.py Outdated Show resolved Hide resolved
Fixed issues in the inventory_controller to raise errors for bad input.
Copy link
Owner

@JeanAEckelberg JeanAEckelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@KingPhilip14 KingPhilip14 merged commit 78eab66 into master Apr 15, 2023
@KingPhilip14 KingPhilip14 deleted the item-inventory-features branch April 15, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants