Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player #17

Merged
merged 8 commits into from
Apr 1, 2023
Merged

Player #17

merged 8 commits into from
Apr 1, 2023

Conversation

JuliaCaesar
Copy link
Collaborator

for the constructor changed action to ActionType for the enum and have just an Action one commented out.
Added type safes to all the setters to ensure valid input

Copy link
Owner

@JeanAEckelberg JeanAEckelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes to the to and from JSON methods

game/common/player.py Outdated Show resolved Hide resolved
game/common/player.py Outdated Show resolved Hide resolved
Copy link
Owner

@JeanAEckelberg JeanAEckelberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@JuliaCaesar JuliaCaesar merged commit 2951bdb into master Apr 1, 2023
@JuliaCaesar JuliaCaesar deleted the player branch April 1, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants