Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documenation to the spritesheet class #146

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Added documenation to the spritesheet class #146

merged 5 commits into from
Jan 12, 2024

Conversation

JeanAEckelberg
Copy link
Owner

No description provided.

@JeanAEckelberg JeanAEckelberg linked an issue Jan 11, 2024 that may be closed by this pull request
Document: spritesheet.py #135
Closed
@JeanAEckelberg JeanAEckelberg self-assigned this Jan 11, 2024
@JeanAEckelberg JeanAEckelberg added the documentation Improvements or additions to documentation label Jan 11, 2024
@JeanAEckelberg JeanAEckelberg enabled auto-merge (squash) January 11, 2024 04:06
KingPhilip14
KingPhilip14 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@KingPhilip14 KingPhilip14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix and you're good

visualizer/utils/spritesheet.py Outdated Show resolved Hide resolved
KingPhilip14
KingPhilip14 requested changes Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@KingPhilip14 KingPhilip14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a small change and this should be fine

MoodyMan04
MoodyMan04 reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@MoodyMan04 MoodyMan04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice documentation! lgtm

KingPhilip14
KingPhilip14 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@KingPhilip14 KingPhilip14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JeanAEckelberg JeanAEckelberg merged commit 2aca4de into master Jan 12, 2024
1 check passed
@JeanAEckelberg JeanAEckelberg deleted the 135-document-spritesheetpy branch January 12, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoodyMan04 MoodyMan04 MoodyMan04 approved these changes

@KingPhilip14 KingPhilip14 KingPhilip14 approved these changes

@JuliaCaesar JuliaCaesar JuliaCaesar approved these changes

@CaitlinAzazel CaitlinAzazel Awaiting requested review from CaitlinAzazel

@CarseKeeper CarseKeeper Awaiting requested review from CarseKeeper

@JosiahErnst JosiahErnst Awaiting requested review from JosiahErnst

Assignees

@JeanAEckelberg JeanAEckelberg

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document: spritesheet.py
4 participants
@JeanAEckelberg @JuliaCaesar @KingPhilip14 @MoodyMan04