Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined PR of ROS1 laser block and CI Workflow with basic frontend test #309

Merged
merged 15 commits into from
Jun 8, 2024

Conversation

BkPankaj
Copy link
Collaborator

@BkPankaj BkPankaj commented Jun 3, 2024

Changes Made

  1. Added a Laser block that supports ROS1. It contains a .json file and has been verified to follow the template used by all blocks.
  2. Added a YAML file that triggers the installation job and performs basic frontend tests whenever a new pull request is made to the master branch.
  3. Wrote the script according to the installation process outlined in the new Visual Circuit documentation.
  4. Implemented action cache for node modules and artifacts for the Python virtual environment to reduce installation time.
  5. In the frontend test, it verifies the presence of the text "File" in the menubar of the VisualCircuit application rendered in App.tsx.

Screenshots

CI Workflow tested in forked repo:

@toshan-luktuke
Copy link
Collaborator

LaserScan couldn't be accessed through the actual UI of the frontend as collection-factory.tsx was not updated. I've made the updates... the rest of the tests look good.

@toshan-luktuke toshan-luktuke merged commit 6aed0e6 into master Jun 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants