Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct error in Threshold Block #179

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

toshan-luktuke
Copy link
Collaborator

Corrected error in the threshold block.
Images of working output:
External:
image
Internal:
image

@Suhas-G
Copy link
Collaborator

Suhas-G commented Aug 2, 2022

Hey...I just noticed now, the parameter name is LowerThreshold in code whereas it is with a space in the block picture, does this work?

@toshan-luktuke
Copy link
Collaborator Author

Thanks a lot for noticing that....it won't work with the space. I've pushed the commit to make the change now 👍
The port name in the code-block has been changed to LowerThreshold, UpperThreshold

@Suhas-G Suhas-G merged commit c878f11 into JdeRobot:master Aug 11, 2022
@toshan-luktuke toshan-luktuke deleted the bugfix/threshold branch February 5, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants