[Bug] Can't change cover image when there is none #49
Labels
bug
Something isn't working
Comments
Jays2Kings
added a commit
that referenced
this issue
May 24, 2020
* Updating the German translation * small fix * added changes done to strings.xml till May 19 * Switch to coil from Glide (#423) * initial coil switch * more coil changes * fix extensions icons * remove last of glide * adjust local manga to actually update the covers as soon as you set it. Also adjusts the large cover and share * edit custom covers of a manga is now immediately reflected * fix edit covers submit not automatically submitting fix edit covers choosing cover not showing the selection in dialog * fix setting custom cover not reloading when going back * get gif's working * run ktlint fix setting custom cover to updated when returning back to details * fix non uniformed covers * get images working on resumes * add size to cover cache setting * remove log statement * remove set last cover date * put covers into cache when refresh enabled * fix comment * Reverted partial rogue commit * Coil updates Non library manga goes into android's default cache Manga Fetcher now respects network cache policy Not showing error drawable on manga details Fixed manga notification icon sometimes not showing General cleanup * Fix toolbar color in manga details when switching themes * Optimizations to sorting + category refactoring Category: • new bool called isDynamic used for all category • new bool called isAlone, for when using no categories or when hiding all categories Sort Optimizing: •Using SQLite query for library mangas to also set the total chapters, instead of checking the total count later •No longer using regex for removing articles from text, because it's pretty heavy •All category now uses the same catergory sorting logic as regular categories * Hide fast scroll when showing backdrop * Added Bottom sheet for menu popup For use in future commits * Using new bottom sheet menu for sorting categories * Added option to change how library is grouped By default (categories) By tag/genre By sources (with the extension icon attached) By status and by tracking status (closes #249) * Fixes for showing single category * Moving hide all categories preference to the group library option Removing the preference for it as well since its in the grouped preference Also adding new wording for group by tracking (tracking status) * Fixed ungrouped library showing "All" * Fix crash in maga details * Tracking status grouping now uses global wording if you have mutliple trackers ie kitsu's "currently reading" becomes "reading" since most trackers use that Also sorting the tracking groups better * Show "no results found" error when search tracker doesn't find anything * Logic fixes to library Fixed trying to update with special groupings Fixed special groups duplicating manga in a list * Grouping menu sheet shows "ungrouped" instead of "categories" by use case For those who not have any categories * Move LibraryHeaderHolder to a new file * when grouping by tags, tags with different casing will be grouped together * Tapping category name now expands backdrop * Category recycler puts active category center of view if list is scrollable Also removed scrolling logic for opening/closing the sheet * Always expose the front view a little bit even when backdrop is too tall Also hide the filter sheet when expanding backdrop Also also ignore the filter sheet when it comes to the layout of the backdrop * Fixed sources with no tags in the manga not having the proper type * Updated logic to elevating the toolbar * Fixed sectioned library showing the wrong category when returning back to library tab when using custom grouping * Using compound drawables for centered toolbar and making the library text centered even with the dropdown arrow showing * Menu bottom sheet now scrolls to the active menu item if list is too tall * Format library xml + no clipping to category backdrop * Always expose the front view a little bit even when backdrop... (p2) Fixing the fact the filter sheet still moved the category recycler view * Don't scroll to the top of the list on group change until view refresh * Option to always show the current category in the title * Refactoring library view create * Use bookmark icon instead of changing text color Didn't look at the upstream code for this, but maybe should've * Added cancel cta to long press library update snackbar * Added "manga" to filter type closes #381 * Edit info for online manga + Custom covers update Yes you read that right. It's back! Oh god it's back Instead of modifying the db, an external json file is made holding the custom info for your library (meaning it's even easier to remove should I so choose) Reworking to just override the variable and use said var instead of having the current/original logic that existed before Custom covers are now saved in a new folder, likewise to upstream Also like upstream, custom covers can be added to manga without covers (closes #49) (I'm so sorry Carlos) * Move "Select target sources" to strings.xml * more strings * missing strings * fix * update * fix * today's updates * remove colon * new strings May 23, 2020 Co-authored-by: Carlos <[email protected]> Co-authored-by: Jay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Device information
Steps to reproduce
Expected behavior
The cover image should change
Actual behavior
The cover image stays black and the app throws an error
Other details
Error: Failed to update cover
The text was updated successfully, but these errors were encountered: