Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: electron dev, prod, package integration #25

Merged
merged 1 commit into from
Apr 10, 2017

Conversation

damnko
Copy link
Collaborator

@damnko damnko commented Apr 8, 2017

Solves #14

Hi @JayKan please let me know what you think about this implementation. I had to change some import paths from absolute to relative because I was having issues during electron packaging.

@JayKan
Copy link
Owner

JayKan commented Apr 9, 2017

@damnko,

What was the reason you've switched from using relative path instead of absolute path on importing modules? For instance, I see you modified the src/filers..

I will look at deeper look at tomorrow and will merge your changes. Thanks a lot for putting this effort @damnko 👍

@damnko
Copy link
Collaborator Author

damnko commented Apr 10, 2017

Yes I changed all the relative paths because I were getting errors like module not found the were solved that way. By the way that was happening while I was trying to build the electron app in another way (I don't remember the details), with electron-packager it works even with absolute paths. So if you'd like I'll revert the paths back to the absolute form they were before, just let me know and I'll update the PR.

@JayKan JayKan merged commit c64d960 into JayKan:master Apr 10, 2017
@JayKan
Copy link
Owner

JayKan commented Apr 10, 2017

@damnko,

A million thanks for putting up your time and get this working. Don't worry about the absolute path issue. I have already merged your awesome code and did some refactoring to take care of this. A few minor things I've noticed and I have created PR for you #26, #27. Other than that, everything looks goood! Once again, thanks A LOT for your help 💯

@damnko
Copy link
Collaborator Author

damnko commented Apr 11, 2017

Thanks I really appreciate your feedback! Looking forward to adding more features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants