Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: divided webpack config into separate builds #23

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

damnko
Copy link
Collaborator

@damnko damnko commented Apr 6, 2017

Before proceeding with #14 I thought to refactor webpack.build.js and split it into separate builds for develop, production and test. Let me know how does it look. I am having problems (in both the current and previous version) running npm run test, does it work on your end?

@JayKan
Copy link
Owner

JayKan commented Apr 6, 2017

@damnko,

Great catch on the npm test errors. For some reasons it's not working currently from my end as well. I will open a PR (#24) for you on setting jasmine testing.

I think Angular2-Webpack-Starter project has a great setup in terms of dev, prod, and test for webpack2. Why don't you follow that project and try to implement the missing testing features?

@JayKan JayKan merged commit 732a0dc into JayKan:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants