Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
poetry run pre-commit run --all-files --show-diff-on-failure
before committing.Description
I added two small improvements to the static typing which will make coding with GPJax a bit easier, especially in fully featured IDEs.
construct_posterior
and__mul__
are overloaded such that the correct posterior (abstract, conjugate or nonconjugate) is returned when we construct the posterior (current behavior is that anAbstractPosterior
is always returned). This way we get proper tab-completion and information (signatures, docstrings) when mouse-hovering on an object.TypeVar
(withModule
as the upper bound) infit
instead ofModule
itself, such that we retain the right static typing information about the model we are using