Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved User Preferences by using Strings instead of Booleans #356

Merged
merged 4 commits into from
Sep 24, 2022

Conversation

jasonlessenich
Copy link
Member

@jasonlessenich jasonlessenich commented Aug 12, 2022

This PR changes the way user preferences are stored. Instead of a simple boolean, this now stores the preferences' value as a string to allow preferences like described in #354

@jasonlessenich jasonlessenich added the enhancement Improvement of an already existing feature label Aug 12, 2022
@jasonlessenich jasonlessenich self-assigned this Aug 12, 2022
@jasonlessenich jasonlessenich requested a review from a team as a code owner August 12, 2022 15:33
@jasonlessenich jasonlessenich changed the title Improved User Preferences by allowing more than just booleans Improved User Preferences by using Strings instead of Booleans Aug 12, 2022
@jasonlessenich jasonlessenich merged commit 5891fe6 into main Sep 24, 2022
@jasonlessenich jasonlessenich deleted the dynxsty/preference_improvements branch September 24, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants