Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZONE_STATES[16] #10

Open
aaronsp777 opened this issue Mar 13, 2018 · 3 comments
Open

ZONE_STATES[16] #10

aaronsp777 opened this issue Mar 13, 2018 · 3 comments

Comments

@aaronsp777
Copy link

There is a typo in concord_commands.py:

I recommend the following change.

ZONE_STATES = {
0: NORMAL,
1: TRIPPED,
2: FAULTED,
4: ALARM,
8: TROUBLE,

  • 10: BYPASSED,
  • 16: BYPASSED,
    }

Furthermore these are bit fields. How to repro: 1) Open Door. 2) Arm panel, 3) Press "#" on panel to arm despite protest. 4) Status comes back as 17 (TRIPPED+BYPASSED).
If you close the door, the status comes back as 16 (Just bypassed)

@JasonCarter80
Copy link
Owner

JasonCarter80 commented Mar 22, 2018 via email

@aaronsp777
Copy link
Author

aaronsp777 commented Mar 22, 2018 via email

@AZDane
Copy link

AZDane commented Aug 19, 2019

In reality it should be handled as a binary instead. Typically you will have a combination - For example Tripped AND Alarm, so that would be a status_code 5

bit 0: 1 = tripped
bit 1: 1 = faulted
bit 2: 1 = Alarm
bit 3: 1 = Trouble
bit 4: 1 = Bypassed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants