-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZONE_STATES[16] #10
Comments
Feel free to make a pull request with the updates, otherwise it might be
some time before one of us gets to it.
|
Ok. Thanks. I know how to clone and check in on my own branch but I don't
know how to do a pull request. I'll try to figure out github. Thanks.
On Mar 22, 2018 7:58 AM, "Jason Carter" <[email protected]> wrote:
Feel free to make a pull request with the updates, otherwise it might be
some time before one of us gets to it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHWcbQM0PNvjkyN_D_SMpLUtqOK7o2RPks5tg7wkgaJpZM4Sn_VM>
.
|
In reality it should be handled as a binary instead. Typically you will have a combination - For example Tripped AND Alarm, so that would be a status_code 5 bit 0: 1 = tripped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a typo in concord_commands.py:
I recommend the following change.
ZONE_STATES = {
0: NORMAL,
1: TRIPPED,
2: FAULTED,
4: ALARM,
8: TROUBLE,
}
Furthermore these are bit fields. How to repro: 1) Open Door. 2) Arm panel, 3) Press "#" on panel to arm despite protest. 4) Status comes back as 17 (TRIPPED+BYPASSED).
If you close the door, the status comes back as 16 (Just bypassed)
The text was updated successfully, but these errors were encountered: