Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarklet languages #999

Closed
wants to merge 7 commits into from
Closed

Conversation

jcuanm
Copy link

@jcuanm jcuanm commented Sep 25, 2015

Add French and Others

</p>

<h4>{% trans %}jda.team.contentdevelopment{% endtrans %}</h4>
<p>{% trans %}jda.team.content.lead{% endtrans %}<br/>
{% trans %}jda.team.content.developer{% endtrans %}<br/>
{% trans %}jda.team.content.curation{% endtrans %}</br>
{% trans %}jda.team.content.cu ration{% endtrans %}</br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is an extra space here that should be removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alex,
I deleted the extra space and tested it in my dev server and now looks fine.
I commited the changes and should take effect in the pending pull request
#1003.

Thanks.

Javier.

On Mon, Oct 5, 2015 at 3:38 PM, Alex Horak [email protected] wrote:

In src/JDA/CoreBundle/Resources/views/Team/team.html.twig
#999 (comment)
:

</p>

<h4>{% trans %}jda.team.contentdevelopment{% endtrans %}</h4>
<p>{% trans %}jda.team.content.lead{% endtrans %}<br/>
{% trans %}jda.team.content.developer{% endtrans %}<br/>
  • {% trans %}jda.team.content.curation{% endtrans %}
  • {% trans %}jda.team.content.cu ration{% endtrans %}

Looks like there is an extra space here that should be removed.


Reply to this email directly or view it on GitHub
https://github.com/Japan-Digital-Archives/Japan-Digital-Archive/pull/999/files#r41206912
.

Javier Cuan

@horak
Copy link
Contributor

horak commented Oct 5, 2015

@jcuanm have you tested this extensively?

@meeshmon
Copy link
Contributor

meeshmon commented Oct 5, 2015

This is the wrong pull request. Javier's editor was malfunctioning. I will delete this pull request.

@meeshmon meeshmon closed this Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants