Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (jans-config-api) : admin-ui apis refactoring #2388

Closed
duttarnab opened this issue Sep 15, 2022 · 0 comments · Fixed by #2390
Closed

feat (jans-config-api) : admin-ui apis refactoring #2388

duttarnab opened this issue Sep 15, 2022 · 0 comments · Fixed by #2390
Assignees
@duttarnab
Labels
comp-jans-config-api Component affected by issue or PR enhancement kind-feature Issue or PR is a new feature request

Comments

@duttarnab
Copy link
Contributor

duttarnab commented Sep 15, 2022 •
edited
Loading

Based on : Admin UI apis suggestion in #2227

AdminPermission

  • should naming be AdminPermission, AdminUIPermission, AdminUIUserPermission?
  • no get for individual permission, only possible to get all permissions at once. At the same time permissions can be individually updated or deleted.
  • which attribute should be the ID? permission?
  • ideally delete should only take the ID of the entity, e.g. permission

AdminRole

  • same concerns as for AdminPermission

AdminRolePermissionMapping

  • same concerns as for AdminPermission

AdminUI permission

  • API is missing attribute defaultPermissionInToken
@duttarnab duttarnab added comp-jans-config-api Component affected by issue or PR enhancement labels Sep 15, 2022
@duttarnab duttarnab self-assigned this Sep 15, 2022
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Sep 15, 2022
duttarnab added a commit that referenced this issue Sep 15, 2022
@duttarnab
feat: admin-ui apis refactoring #2388
608b31b
@duttarnab duttarnab mentioned this issue Sep 15, 2022
Merged
yuriyz pushed a commit that referenced this issue Sep 15, 2022
@duttarnab
feat: admin-ui apis refactoring #2388 (#2390)
c7b26e9
duttarnab added a commit that referenced this issue Sep 15, 2022
@duttarnab
feat: admin-ui apis refactoring #2388
c2bd712
@duttarnab duttarnab mentioned this issue Sep 15, 2022
Closed
@mo-auto mo-auto mentioned this issue Nov 1, 2022
Merged
@mo-auto3 mo-auto3 mentioned this issue Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duttarnab duttarnab

Labels
comp-jans-config-api Component affected by issue or PR enhancement kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: admin-ui apis refactoring #2388 JanssenProject/jans
2 participants
@duttarnab @mo-auto