Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-auth-server): rename enabledComponents conf property -> featureFlags #2290

Closed
yuriyz opened this issue Sep 1, 2022 · 2 comments · Fixed by #2319
Closed

feat(jans-auth-server): rename enabledComponents conf property -> featureFlags #2290

yuriyz opened this issue Sep 1, 2022 · 2 comments · Fixed by #2319
Assignees
@yuriyz
Labels
comp-jans-auth-server Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality kind-feature Issue or PR is a new feature request
Milestone
1.0.3

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Sep 1, 2022 •
edited
Loading

Description

Rename enabledComponents conf property -> featureFlags

Mike: enabledComponents sounds like big stuff, like auth-server, fido, scim
YuriyZ: we need better name for it
Mike: featureFlags would help us with security audit… then we can say we have “feature flags”
@yuriyz yuriyz added kind-enhancement Issue or PR is an enhancement to an existing functionality comp-jans-auth-server Component affected by issue or PR labels Sep 1, 2022
@yuriyz yuriyz added this to the 1.0.3 milestone Sep 1, 2022
@yuriyz yuriyz self-assigned this Sep 1, 2022
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Sep 1, 2022
@nynymike
Copy link
Contributor

nynymike commented Sep 6, 2022

Can you give some examples of what the values are here?

@yuriyz
Copy link
Contributor Author

yuriyz commented Sep 6, 2022

Example

"enabledComponents": [
  "health_check",
  "userinfo", 
  "clientinfo", 
  "id_generation", 
  "registration",
  "introspection", 
  "revoke_token", 
  "revoke_session", 
  "active_session",
  "end_session", 
  "status_session", 
  "jans_configuration", 
  "ciba",
  "uma", 
  "u2f",
  "device_authz",
  "stat",
  "par"
]

yuriyz added a commit that referenced this issue Sep 7, 2022
@yuriyz
feat(jans-auth-server): renamed "enabledComponents" conf property -> …
5c70d6a 
…"featureFlags" #2290

docs: no docs (config-api swagger updated)
#2290
@yuriyz yuriyz mentioned this issue Sep 7, 2022
Merged
5 tasks
yuriyz added a commit that referenced this issue Sep 7, 2022
@yuriyz
feat(jans-auth-server): renamed "enabledComponents" conf property -> …
56a33c4 
…"featureFlags" #2290 (#2319)

docs: no docs (config-api swagger updated)
#2290
This was referenced Nov 1, 2022
Merged
Merged
This was referenced Nov 1, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
1.0.3
3 participants
@yuriyz @nynymike @mo-auto