This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
Fix Adding Books for Win32 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 6, 2019 12:45
On the win32 platform ID was coming as the fully qualified path to the file which caused issues both adding the cover image and retreiving the epub file from books.json. We now split the ID on \ and take the last element which should be the name of the key we need for the database.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR correctly allows users to add and read ePubs on at least Windows 10 x64 which fixes this issue. You can see screenshots here
The ID/Key was being set as the fully qualified path to the epub and it needed to be parsed to only take the name after the final
\character.There is also a bit of whitespace cleanup in here since my editor strips it automatically on save. There is also a commit that corrected some typos.