include all the wasmtime runtime libs in the package more ergonomically #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
force-pushed
the
dev/janpro/package_and_template
branch
from
e1866c8 to
d799db0
Compare
baronfel
commented
Aug 1, 2024
| @@ -66,9 +52,15 @@ | |||
| FinalOutputPath="$(ProjectDepsFilePath)" /> | |||
| </ItemGroup> | |||
| </Target> | |||
|
|
|||
| <Target Name="IncludeWasmLibs" BeforeTargets="_GetPackageFiles"> | |||
There was a problem hiding this comment.
this is kind of dirty, but we get no other hook since we don't have a per-RID inclusion hook for package, and there's no central package files hook yet either.
rainersigwald
approved these changes
Aug 1, 2024
|
Thanks, but I will have to look into it more. I reverted it because it causes that the users of MSBuildWasm also need to include the Wasmtime package in .proj file, which is undesirable. |
JanProvaznik
added a commit
that referenced
this pull request
Aug 5, 2024
* package and add template project based on package * fix ci * fix solution file * reference locla msbuild dlls, not package * pin msbuild version in ci * use package in tests * pin msbuild submodule remove lock files add logo and readme to package * add license * add TODOs to consider * include all the wasmtime runtime libs in the package more ergonomically (#17) * Revert "include all the wasmtime runtime libs in the package more ergonomical…" (#18) This reverts commit b54a580. * Update licensing fix UsingTask check to avoid restore issues * improve packaging * better packaging of native dependencies * include all the wasmtime runtime libs in the package more ergonomically --------- Co-authored-by: Jan Provazník <[email protected]> * make template package --------- Co-authored-by: YuliiaKovalova <[email protected]> Co-authored-by: Chet Husk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package layout after this change: